Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Meteor0id enhance ringing sounds #12390

Closed

Conversation

Sgn-32
Copy link
Contributor

@Sgn-32 Sgn-32 commented Aug 12, 2022

Contributor checklist

  • Moto X Play, Android 7.1.1
  • My contribution is fully baked and ready to be merged as is

Description

PR with @Meteor0id improved sound files for outgoing and busy calling sound.
Learn more: #8948

@Meteor0id
Copy link
Contributor

There are also two other files which could potentially be added to this PR but those would require some code changes:

  1. a sound for the connecting / establishing phase of a call. This one sounds very similar to outing, with only a minor difference in the time between each ring sound. The goal is to make the difference between connecting and actually calling audible to people who cannot easily read their screen (accessibility).
  2. A call ended sound. Don't you just hate when someone hangs up and you have to check your screen to make sure the call actually ended? It's just a single low tone beep.

Would be nice to add those too but if you end up just merging outgoing and busty sounds that's still a nice enhancement.

@stale
Copy link

stale bot commented Oct 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 18, 2022
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Oct 19, 2022

This issue has been automatically marked as stale...

This isn't an issue, it's a PR.
I hope design prefers a clear ringtone and not noisy ones.

@stale stale bot removed the wontfix label Oct 19, 2022
@clauz9
Copy link
Contributor

clauz9 commented Oct 20, 2022

ha ha... The bot got his wires crossed 🤣

@cody-signal
Copy link
Contributor

I've brought this up to design multiple times, it's in their court.

@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2022
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Dec 21, 2022

Still no news from Design?
Since it's Christmas, I hope Design gets a good music system as a gift.
So they no longer need to use a gramophone for sound tests.

@stale stale bot removed the wontfix label Dec 21, 2022
@stale
Copy link

stale bot commented Mar 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 26, 2023
@UnderscoreX5
Copy link

We seem to be getting a calls overhaul but the sound hasn't been touched upon yet.. I really hope they work on it since it's a stupidly simple task compared to all the awesome work they've done for calls in the current beta.

@stale stale bot removed the wontfix label Mar 28, 2023
@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 9, 2023
@Meteor0id
Copy link
Contributor

Such a simple fix, lets not waste it by ignoring it

@stale
Copy link

stale bot commented Sep 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 9, 2023
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Sep 9, 2023

A comment for stalebot

@stale stale bot removed the wontfix label Sep 9, 2023
Copy link

stale bot commented Nov 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 9, 2023
@Meteor0id
Copy link
Contributor

.

@stale stale bot removed the wontfix label Nov 9, 2023
Copy link

stale bot commented Jan 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 8, 2024
@Meteor0id
Copy link
Contributor

Kick

@stale stale bot removed the wontfix label Jan 8, 2024
Copy link

stale bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 8, 2024
@Meteor0id
Copy link
Contributor

Signals noicy ribgtones still hurt my ears. I love the authentic old sound but the noice shouldn't be part if it

@stale stale bot removed the wontfix label Mar 9, 2024
@Sgn-32 Sgn-32 mentioned this pull request Mar 28, 2024
3 tasks
Copy link

stale bot commented May 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 8, 2024
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented May 12, 2024

Why not test it in the next beta and get feedback from the beta testers?

@stale stale bot removed the wontfix label May 12, 2024
Copy link

stale bot commented Jul 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 13, 2024
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Jul 14, 2024

Oh no, stale-bot.

@stale stale bot removed the wontfix label Jul 14, 2024
Copy link

stale bot commented Sep 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 13, 2024
@cody-signal
Copy link
Contributor

For anyone curious, this is still true:

I've brought this up to design multiple times, it's in their court.

Copy link

stale bot commented Sep 20, 2024

This issue has been closed due to inactivity.

@stale stale bot closed this Sep 20, 2024
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Oct 4, 2024

Stale-bot! Why closed?
A dev has commented after marking as "wontfix".
Shouldn't comments from devs remove the "wontfix"-label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants